VideoFrame.as_array() supports more pixel formats #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uding 10 bit formats
…that should also work with grey frames
crnbaker
force-pushed
the
7_rgb_video_decoding
branch
from
49d8d2e to
077fcfd
Compare
crnbaker
force-pushed
the
7_rgb_video_decoding
branch
from
277f810 to
57a6ae6
Compare
crnbaker
force-pushed
the
7_rgb_video_decoding
branch
from
57a6ae6 to
26f6a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
VideoFrame.as_array()can now decode all RGB/BGR formats including RGB10 and BGR10, as well as grayscale formats.There are some new optional keyword arguments to control the order of the channels in the resulting array.
The decoding is implemeneted in Python. However, for testing purposes it is now possible to generate mock frames (using
MockProCaptureDevice) in formats other than RGB24, but this requires ffmpeg be installed. Since this functionality is only intended for testing, ffmpeg has not been included as a requirement.