Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreated ddo landing page to mirror elements from www. #903

Closed
wants to merge 3 commits into from

Conversation

sraby
Copy link
Member

@sraby sraby commented Oct 28, 2019

No description provided.

@sraby sraby changed the title recreated ddo landing page to mirror elements from www. Recreated ddo landing page to mirror elements from www. Oct 28, 2019
@sraby
Copy link
Member Author

sraby commented Oct 28, 2019

[ch632]

@toolness
Copy link
Collaborator

Uh-oh, I'm getting the following errors on Edge and IE11:

TypeError: Invalid calling object
   at requestTimeout (eval code:41:3)
   at componentDidMount (eval code:125:7)
   at commitLifeCycles (eval code:17334:13)
   at commitAllLifeCycles (eval code:18736:7)
   at callCallback (eval code:149:9)

with the following React component stack:

    in TextLoop (created by Form)
    in div (created by Form)
    in h1 (created by Form)
    in div (created by Form)
    in section (created by Form)
    in form (created by Form)
    in Form (created by FormSubmitterWithoutRouter)
    in FormSubmitterWithoutRouter (created by Context.Consumer)
    in Route (created by FormSubmitter)
    in FormSubmitter (created by QueryFormSubmitter)
    in QueryFormSubmitter (created by DataDrivenOnboardingPage)
    in div (created by Page)
    in Page (created by DataDrivenOnboardingPage)
    in DataDrivenOnboardingPage (created by Context.Consumer)
    in Route (created by DataDrivenOnboardingRoutes)
    in DataDrivenOnboardingRoutes (created by InnerLoadable)
    in InnerLoadable (created by Context.Consumer)
    in Unknown (created by ForwardRef)
    in ForwardRef (created by Context.Consumer)
    in Route (created by Context.Consumer)
    in Switch (created by Context.Consumer)
    in Route (created by AppWithoutRouter)
    in div (created by LoadingOverlayManagerWithoutRouter)
    in LoadingOverlayManagerWithoutRouter (created by Context.Consumer)
    in Route (created by withRouter(LoadingOverlayManagerWithoutRouter))
    in withRouter(LoadingOverlayManagerWithoutRouter) (created by AppWithoutRouter)
    in div (created by AppWithoutRouter)
    in section (created by AppWithoutRouter)
    in AriaAnnouncer (created by AppWithoutRouter)
    in HistoryBlockerManagerWithoutRouter (created by Context.Consumer)
    in Route (created by withRouter(HistoryBlockerManagerWithoutRouter))
    in withRouter(HistoryBlockerManagerWithoutRouter) (created by AppWithoutRouter)
    in ErrorBoundary (created by AppWithoutRouter)
    in AppWithoutRouter (created by Context.Consumer)
    in Route (created by withRouter(AppWithoutRouter))
    in withRouter(AppWithoutRouter)
    in Router (created by BrowserRouter)
    in BrowserRouter
    in HelmetProvider

It looks like this might be a bug in the react-text-loop component? If you're using the same component on the org website, then it might not work on Edge/IE11 there too...

@toolness
Copy link
Collaborator

So an extremely weird thing about this IE/Edge bug is that it might only appear on development and not on production, if the conversation on tus/tus-js-client#77 is any indication. Ugggh.

@toolness toolness closed this Feb 18, 2021
@toolness toolness deleted the ddo-landing-text-update branch February 18, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants