Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DDO the primary homepage #854

Merged

Conversation

toolness
Copy link
Collaborator

@toolness toolness commented Sep 16, 2019

Users who did HP Action can't send a LoC from the Take Action page because the current LoC splash page redirects the user to the latest step of their signup intent (e.g., HP Action) if they're already logged in.

We also want to make the root ("homepage") of the site be data-driven onboarding (DDO), not the LoC splash page.

This fixes the above issues by adding an explicit LoC splash page at /loc/splash, and making the site root be DDO. We also redirect the old /ddo to the site root, passing along the search params as needed.

To do

  • Once Add link to LoC and HP action from login page #888 is merged, merge master back into this PR and make sure the LoC link on the login page points to the splash page.
  • Make the homepage DDO.
  • Redirect DDO to the homepage, so that old/bookmarked links pointing to DDO still work.
  • Ensure that when users log in, we don't redirect them to a blank search screen. And that if they click on the JustFix logo, it does the same thing as clicking "Take Action" on the navbar.

@toolness
Copy link
Collaborator Author

Note that once #888 is merged, we'll want to replace the LoC link there too!

@toolness toolness changed the title Add an explicit LoC splash page at /loc/splash. Make DDO the primary homepage Oct 18, 2019
@toolness
Copy link
Collaborator Author

[ch414]

@toolness toolness merged commit 913ed6c into master Oct 30, 2019
@toolness toolness deleted the atulvarma/ch370/users-who-did-hp-action-can-t-send-loc-from branch October 30, 2019 15:51
toolness added a commit that referenced this pull request Oct 30, 2019
toolness added a commit that referenced this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant