Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #52

Merged
merged 16 commits into from
Jan 26, 2021
Merged

Improve code quality #52

merged 16 commits into from
Jan 26, 2021

Conversation

JulienPeloton
Copy link
Owner

@JulienPeloton JulienPeloton commented Jan 25, 2021

In this PR, we check the code quality with a linter (flake8). Here is the command used:

black -l 86 s4cmb/*
flake8 s4cmb/*.py --count --show-source --statistics --max-line-length 86 --doctests --ignore=E741,W605

Missing:

  • Add the command above in the GH actions checks (a different workflow)

@coveralls
Copy link

coveralls commented Jan 26, 2021

Coverage Status

Coverage increased (+0.01%) to 86.949% when pulling 35a7263 on issues/51/codequality into ec064cd on master.

@JulienPeloton JulienPeloton merged commit 1fe483a into master Jan 26, 2021
@JulienPeloton JulienPeloton mentioned this pull request Feb 1, 2021
@JulienPeloton JulienPeloton deleted the issues/51/codequality branch February 1, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants