Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md update: more accurate patch #89

Closed
wants to merge 1 commit into from
Closed

README.md update: more accurate patch #89

wants to merge 1 commit into from

Conversation

Pomis
Copy link

@Pomis Pomis commented Oct 29, 2021

I have about 50 playlists, and with current patch the scrollable area was still cropped

I have about 50 playlists, and with current patch the scrollable area was still cropped
@SendNukez
Copy link
Collaborator

I'm not familiar with how the patching works. Maybe @JulienMaille knows more. But you also have to change the install scripts to include the change.

@Pomis Pomis closed this Nov 1, 2021
@JulienMaille
Copy link
Owner

Why did you close it?

@Pomis
Copy link
Author

Pomis commented Nov 1, 2021

CI job was trying to check out from this repo, though the branch was in my fork, and thus failing

@JulienMaille
Copy link
Owner

Can you explain what the patch does? Why changing that value does fix the scrolling issue? Thanks

@Pomis
Copy link
Author

Pomis commented Nov 1, 2021

Because stock Spotify playlist item height is 32, and in the theme height was increased, and changing this specific value makes calculation of scroll extent area correspondent to the actual height. I don't know exactly how it works, seems like a replacement of value using regex, but with what it has initially in Readme, it clipped several playlists for me

@JulienMaille
Copy link
Owner

CI job was trying to check out from this repo, though the branch was in my fork, and thus failing

@SendNukez is it a bug with the CI?

JulienMaille added a commit that referenced this pull request Nov 2, 2021
@SendNukez
Copy link
Collaborator

Seems to be a problem with the checkout action. I'll look into it.

JulienMaille added a commit that referenced this pull request Nov 2, 2021
JulienMaille added a commit that referenced this pull request Nov 3, 2021
Scroll extent calculated wrongly - clean version of PR #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants