Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Invalidations.yml #10

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Create Invalidations.yml #10

merged 1 commit into from
Sep 1, 2022

Conversation

ranocha
Copy link
Contributor

@ranocha ranocha commented Sep 1, 2022

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/ranocha/MIMEs.jl", rev="patch-1")
julia> using MIMEs

Or run this code in your browser: Run with binder

@fonsp
Copy link
Member

fonsp commented Sep 1, 2022

Thanks for the contributions to JuliaWeb!

For MIMEs.jl, I think that the subject of invalidations does not really apply, because the package contains a small number of simple functions that will never be extended with additional methods. We have 0 invalidations currently ( https://github.com/JuliaWeb/MIMEs.jl/runs/8137852412?check_suite_focus=true#step:9:1 ).

I will close this for now but feel free to continue the discussion and I will re-open. Thanks again!

@fonsp fonsp closed this Sep 1, 2022
@ranocha
Copy link
Contributor Author

ranocha commented Sep 1, 2022

Hi! First of all, thanks for many great packages. It's great to hear that this package does not cause any invalidations at the moment. We also had some discussion in SciML about this but decided that it's always better for us to accept increased CI workload to reduce human working time, see SciML/MuladdMacro.jl#26 (comment)
You are of course free to make your own decision. My intention was just to provide a tool to help reducing invalidations and thereby latency problems in Julia. If this package is already basically in its final state and will never add invalidations, you don't need to add this, of course.

@fonsp fonsp reopened this Sep 1, 2022
@fonsp fonsp merged commit d80ba0f into JuliaWeb:main Sep 1, 2022
@ranocha ranocha deleted the patch-1 branch September 1, 2022 15:05
@fonsp
Copy link
Member

fonsp commented Nov 6, 2024

@ranocha FYI the compat file did not work on Julia 1.11, I had to change it to Julia 1.10 to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants