Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistent_tasks: suppress logs from Pkg.jl #256

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

aviatesk
Copy link
Contributor

By using io=devnull option, which is only available in Julia 1.9 and above.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e9a4230) 75.33% compared to head (797ab09) 70.68%.

Files Patch % Lines
src/persistent_tasks.jl 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   75.33%   70.68%   -4.66%     
==========================================
  Files          11       11              
  Lines         750      747       -3     
==========================================
- Hits          565      528      -37     
- Misses        185      219      +34     
Flag Coverage Δ
unittests 70.68% <0.00%> (-4.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens
Copy link
Collaborator

Thanks for your PR!
The whole test is only run for julia 1.10 and later (see https://github.com/JuliaTesting/Aqua.jl/pull/256/files#diff-f727412b094adb6463b973046def5a3004e1e292aca989b8b4564ce26f5132feR121), so you don't need all of these @static if everywhere.

By using `io=devnull` option, which is only available in Julia 1.9
and above.
@aviatesk
Copy link
Contributor Author

Thanks for your review! Updated.

Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks! I'll proceed with this and add a changelog entry.

@lgoettgens lgoettgens merged commit ce2a7d6 into JuliaTesting:master Nov 29, 2023
21 of 23 checks passed
lgoettgens referenced this pull request Nov 29, 2023
* Small docs adjustments

* Split docs into one file per test

* Enable Documenter checks

* Add more docs for `ambiguities`

* Move parts of docstring of `test_persistent_tasks` to docs

* Add docs for `deps_compat`

* Move parts of docstring of `test_unbound_args` to docs

* Add docs for `project_extras`

* Add docs for `piracies`

* Add more docs

* Add changelgog

* Apply suggestions from code review

Co-authored-by: Yuto Horikawa <[email protected]>

* Apply suggestions from code review

* Update docs/src/unbound_args.md

* Update docs/src/unbound_args.md

---------

Co-authored-by: Yuto Horikawa <[email protected]>
@aviatesk aviatesk deleted the avi/io-devnull branch November 29, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants