-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
persistent_tasks: suppress logs from Pkg.jl #256
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
==========================================
- Coverage 75.33% 70.68% -4.66%
==========================================
Files 11 11
Lines 750 747 -3
==========================================
- Hits 565 528 -37
- Misses 185 219 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5edb672
to
98e2412
Compare
Thanks for your PR! |
By using `io=devnull` option, which is only available in Julia 1.9 and above.
98e2412
to
2d9a3a4
Compare
Thanks for your review! Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks! I'll proceed with this and add a changelog entry.
* Small docs adjustments * Split docs into one file per test * Enable Documenter checks * Add more docs for `ambiguities` * Move parts of docstring of `test_persistent_tasks` to docs * Add docs for `deps_compat` * Move parts of docstring of `test_unbound_args` to docs * Add docs for `project_extras` * Add docs for `piracies` * Add more docs * Add changelgog * Apply suggestions from code review Co-authored-by: Yuto Horikawa <[email protected]> * Apply suggestions from code review * Update docs/src/unbound_args.md * Update docs/src/unbound_args.md --------- Co-authored-by: Yuto Horikawa <[email protected]>
By using
io=devnull
option, which is only available in Julia 1.9 and above.