-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_persistent_tasks: Add an optional expr
to run in the precompile package
#255
Conversation
8be12e6
to
d0cca64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 75.20% 75.20%
=======================================
Files 11 11
Lines 750 750
=======================================
Hits 564 564
Misses 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I see where this is coming from and how this can be useful. Some comment from the first look: I would prefer |
9041e85
to
af5ffd7
Compare
…e package Bump version to 0.8.4
af5ffd7
to
eabc74b
Compare
Okay! Thanks @lgoettgens. I rebased on master, fixed the merge conflicts, added a test case, and changed expr to a keyword argument. The reason I had made it a positional argument at first was because I wasn't sure what a good name should be. Is expr okay? Should it be precompile_expr? |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I have some minor comments, could you have a look at them? Once they are resolved, I'll update this PR for a version bump and do the merge/release procedure.
I have no real preference between the two. |
Co-authored-by: Lars Göttgens <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I think this is all set! Thanks for the nice review 😊 ❤️
Co-authored-by: Lars Göttgens <[email protected]>
Thanks! Should be all done then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
(From this slack discussion)
Here's an example of it working!