Fix handling of Shift_JISx0213 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For stateful encodings, we need to copy the contents of the output buffer to the stream after calling `iconv_reset!`. Otherwise the bytes that may be written remain in the buffer. We als oneed to `close` from `encode`, which incidentally ensures that objects can be freed immediately.
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 91.51% 91.55% +0.03%
==========================================
Files 2 2
Lines 224 225 +1
==========================================
+ Hits 205 206 +1
Misses 19 19
Continue to review full report at Codecov.
|
This was referenced Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For stateful encodings, we need to copy the contents of the output buffer to the stream after calling
iconv_reset!. Otherwise the bytes that may be written remain in the buffer. We als oneed toclosefromencode, which incidentally ensures that objects can be freed immediately.Fix #49.