Update sampling.jl #559
Closed
Update sampling.jl #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable `make_alias_table!()` for all float types. It would be useful to enable e.g. `AliasTable()` in `Distributions.jl` to create object with element type other than `Float64`.
githubtomtom
added a commit
to githubtomtom/Distributions.jl
that referenced
this pull request
Feb 24, 2020
enable `rand()` from non-Float64 mixtures, e.g. `MixtureModel{Univariate,Continuous,Normal,Float32}`, now only `Float64` element type is supported.
a related [pull request](JuliaStats/StatsBase.jl#559) is made in `StatsBase. make_alias_table!()`.
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 90.57% 90.58% +<.01%
==========================================
Files 21 21
Lines 2239 2240 +1
==========================================
+ Hits 2028 2029 +1
Misses 211 211
Continue to review full report at Codecov.
|
|
a related pull request is made in |
|
Ping! is there anything holding back merging this PR? |
|
This should be fixed more generally, not only for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable
make_alias_table!()for all float types. It would be useful to enable e.g.AliasTable()inDistributions.jlto create object with element type other thanFloat64.