Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MDS API #85

Merged
merged 6 commits into from
May 21, 2019
Merged

New MDS API #85

merged 6 commits into from
May 21, 2019

Conversation

wildart
Copy link
Collaborator

@wildart wildart commented Dec 28, 2018

Changed cMDS to have a standard fit/transform API

New:

Added:

@kmundnic
Copy link

kmundnic commented Aug 18, 2019

I've been trying to use the implementation classical_mds and the new API in the master branch, and it seems that both are making the assumption that the distance matrix has entries D[i,j] = norm(X[:,i] - X[:,j], 2). However, by definition a Euclidean Distance Matrix (EDM) uses square Euclidean distances for its entries (this can be found in your reference, chapter 12), and on this paper (which follows the same approach: https://arxiv.org/pdf/1502.07541.pdf).

The result is that when computing an embedding Z from a distance matrix D, where D[i,j] = norm(X[:,i] - X[:,j], 2)^2 and X is our original (underlying) embedding, X and Z do not match up to an affine transformation, as they should (see Section II. C. Orthogonal Procrustes Problem of the paper referenced from ArXiv).

Given the reference in use in the documentation, I think it should be good to use distance matrices with squared Euclidean distances. However, if there is no consensus on this idea, I would suggest stating in the documentation that the distances matrices are assumed to have Euclidean distance entries.

Thanks!

Edit: Please let me know if I should open an issue instead of including this comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants