Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some docstrings #1404

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Fix some docstrings #1404

merged 2 commits into from
Oct 11, 2021

Conversation

st--
Copy link
Contributor

@st-- st-- commented Oct 11, 2021

Follow-up from reviewing #1403

@@ -1,5 +1,5 @@
"""
Beta(α,β)
Beta(α, β)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB- both forms are present in various docstrings at the moment; I did not go through to make ALL of them consistent yet, only the ones I was editing anyways.

Comment on lines -30 to -44
Chernoff()
pdf(Chernoff(),x::Real)
cdf(Chernoff(),x::Real)
logpdf(Chernoff(),x::Real)
survivor(Chernoff(),x::Real)
mean(Chernoff())
var(Chernoff())
skewness(Chernoff())
kurtosis(Chernoff())
kurtosis(Chernoff(), excess::Bool)
mode(Chernoff())
entropy(Chernoff())
rand(Chernoff())
rand(rng, Chernoff()
cdf(Chernoff(),-x) #For tail probabilities, use this instead of 1-cdf(Chernoff(),x)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the only distribution that has all the methods in the docstring; it only seems to make sense to keep the ones that are only defined for a distribution or have very specific behavior, so the only one I kept was the last one, but I'm happy to hear your thoughts on what this should be:)

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #1404 (47a169b) into master (6817b1c) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1404      +/-   ##
==========================================
+ Coverage   82.99%   83.05%   +0.05%     
==========================================
  Files         117      117              
  Lines        6751     6756       +5     
==========================================
+ Hits         5603     5611       +8     
+ Misses       1148     1145       -3     
Impacted Files Coverage Δ
src/univariate/continuous/beta.jl 70.43% <ø> (ø)
src/univariate/continuous/betaprime.jl 92.50% <ø> (ø)
src/univariate/continuous/cauchy.jl 80.95% <ø> (ø)
src/univariate/continuous/chernoff.jl 31.88% <ø> (ø)
src/univariate/continuous/symtriangular.jl 90.74% <ø> (ø)
src/univariates.jl 74.33% <0.00%> (-0.14%) ⬇️
src/multivariate/product.jl 100.00% <0.00%> (ø)
src/multivariate/mvnormal.jl 74.34% <0.00%> (+0.27%) ⬆️
src/common.jl 66.66% <0.00%> (+0.95%) ⬆️
src/univariate/continuous/normalcanon.jl 89.18% <0.00%> (+8.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6817b1c...47a169b. Read the comment docs.

@devmotion devmotion merged commit 27fb31c into JuliaStats:master Oct 11, 2021
@st-- st-- deleted the st/docstrings branch October 11, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants