tests to use fallback exception to handle FieldError exception
#539
Conversation
|
JuliaLang/julia#54504 is not merged yet. So all tests will fail. But we need these for original PR. So how do we handle this ? |
test/spqr.jl
Outdated
| @@ -39,7 +39,7 @@ itypes = sizeof(Int) == 4 ? (Int32,) : (Int32, Int64) | |||
| @test istriu(F.R) | |||
| @test isperm(F.pcol) | |||
| @test isperm(F.prow) | |||
| @test_throws ErrorException F.T | |||
| @test_throws FieldError F.T | |||
There was a problem hiding this comment.
| @test_throws FieldError F.T | |
| @test_throws Exception F.T |
This will work both before and after #54504 (suggested by Eric Hanson on slack)
There was a problem hiding this comment.
Is this temporary solution ?
There was a problem hiding this comment.
could also do @test_throws Union{FieldError, ErrorException} F.T if we want to be a little more precise and only allow those 2
There was a problem hiding this comment.
I like this. I didn't know we can do that. Thanks.
There was a problem hiding this comment.
We can't do that Union because FieldError does not exist. We could do @test_throws isdefined(Base, :FieldError) ? FieldError : ErrorException F.T
There was a problem hiding this comment.
Sorry I should have tested on local PC first. I tested it this time.
arhik
changed the title
FieldError exception insteadFieldError exception
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 84.07% 83.73% -0.34%
==========================================
Files 12 12
Lines 9068 9046 -22
==========================================
- Hits 7624 7575 -49
- Misses 1444 1471 +27 ☔ View full report in Codecov by Sentry. |
with PR#54504 field access exception is raised as `FieldError` exception now.
|
CI tests pass, though codecov upload fails. I see a similar pattern on other merged PRs. I'm assuming it's just the codecov setup being unreliable. |
with #54504 field access exception is raised as
FieldErrorexception now.