Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality cleanup #438

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Code quality cleanup #438

merged 5 commits into from
Sep 4, 2023

Conversation

dkarrasch
Copy link
Member

This PR contains a few small edits that should be backported to v1.10.

  • resolve a method ambiguity in a rare case (previously, we didn't check method ambiguity because there was no way to distinguish the methods in the sysimage from those same in this package)
  • apparently, an update of Aqua.jl allows us to tighten some code quality checks

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #438 (a8271b4) into main (4e6776a) will increase coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   92.42%   93.19%   +0.76%     
==========================================
  Files          12       12              
  Lines        7667     7667              
==========================================
+ Hits         7086     7145      +59     
+ Misses        581      522      -59     
Files Changed Coverage Δ
src/linalg.jl 91.56% <100.00%> (+4.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matbesancon
Copy link
Contributor

good to merge?

@dkarrasch dkarrasch merged commit 03ed9e3 into main Sep 4, 2023
@dkarrasch dkarrasch deleted the dk/cleanup branch September 4, 2023 12:44
dkarrasch added a commit that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants