Make cholmod vector solve return vector
#320
Conversation
| @@ -1526,7 +1544,10 @@ end | |||
| function (\)(L::FactorComponent, B::Matrix) | |||
| Matrix(L\Dense(B)) | |||
| end | |||
| function (\)(L::FactorComponent, B::SparseVecOrMat) | |||
| function (\)(L::FactorComponent, B::SparseVector) | |||
| sparsevec(L\Sparse(B)) | |||
There was a problem hiding this comment.
I'm a little confused about why we are returning a sparse vector — isn't the result generally dense?
There was a problem hiding this comment.
I was confused about that myself, but note that previously we returned a SparseMatrixCSC. This change only changes the dimension of the returned array. But, of course, we may as well change to dense return arrays. The actual type of the return value doesn't seem to be tested, so I don't know what "promises" we made.
There was a problem hiding this comment.
I guess we might as well stay consistent here.
See also https://discourse.julialang.org/t/sparse-solve-with-sparse-rhs/81595/3?u=stevengj
Codecov Report
@@ Coverage Diff @@
## main JuliaLang/julia#320 +/- ##
==========================================
- Coverage 93.71% 93.71% -0.01%
==========================================
Files 12 12
Lines 7433 7446 +13
==========================================
+ Hits 6966 6978 +12
- Misses 467 468 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM. |
|
Merge? |
Fixes JuliaLang/LinearAlgebra.jl#977.