Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfering CSM 8a into parent #892

Merged
merged 35 commits into from
Sep 18, 2020
Merged

Conversation

dehann
Copy link
Member

@dehann dehann commented Sep 10, 2020

Mental model for what steps might be for untangling "CSM 8a pull model (#674)" which is required to resolve "#459 dwnMsg consolidation":

  • redirect 4b needdownmsg to 7 instead (replacing 4c direction)
  • absorb 4c into 7
  • redirect 7 away from 7c, but to 8j instead
  • add path from new 7 to 8a
  • Redirect 8a away from 8j, but perhaps to 7b instead
  • Finally fix 8a to pull model which should now be running in parent csm instead.

@dehann dehann added this to the v0.16.0 milestone Sep 10, 2020
@dehann dehann changed the title transfering 8a into parent CSM transfering CSM 8a into parent Sep 10, 2020
@dehann dehann marked this pull request as ready for review September 18, 2020 06:30
@dehann dehann marked this pull request as draft September 18, 2020 06:30
@dehann dehann marked this pull request as ready for review September 18, 2020 10:00
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #892 into maint/20Q3/fixdown#459 will decrease coverage by 1.78%.
The diff coverage is 68.45%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           maint/20Q3/fixdown#459     #892      +/-   ##
==========================================================
- Coverage                   62.23%   60.44%   -1.79%     
==========================================================
  Files                          42       43       +1     
  Lines                        4748     4953     +205     
==========================================================
+ Hits                         2955     2994      +39     
- Misses                       1793     1959     +166     
Impacted Files Coverage Δ
src/BeliefTypes.jl 25.00% <ø> (ø)
src/IncrementalInference.jl 80.00% <ø> (ø)
src/InferDimensionUtils.jl 70.45% <0.00%> (-12.31%) ⬇️
src/JunctionTreeTypes.jl 21.85% <ø> (-3.00%) ⬇️
src/TreeMessageUtils.jl 53.95% <ø> (-8.89%) ⬇️
src/Deprecated.jl 0.75% <2.00%> (-10.23%) ⬇️
src/CliqStateMachineUtils.jl 51.75% <28.33%> (-6.41%) ⬇️
src/SolverAPI.jl 67.07% <40.00%> (ø)
src/SolveTree.jl 58.73% <45.45%> (-0.37%) ⬇️
src/TreeMsgDwnConsolidation.jl 74.44% <82.14%> (+16.11%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59574f2...8704e59. Read the comment docs.

@dehann
Copy link
Member Author

dehann commented Sep 18, 2020

finalizes pull model on #674

@dehann dehann merged commit 2110565 into maint/20Q3/fixdown#459 Sep 18, 2020
@dehann dehann deleted the twig/3Q20/dwn459/fix674 branch January 5, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants