Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First state machine tree init (single core) #273

Merged
merged 6 commits into from
May 7, 2019
Merged

Conversation

dehann
Copy link
Member

@dehann dehann commented May 7, 2019

The idea is to initialize factor graph variables using the Bayes tree and not just on the factor graph, or worse to just punt initialization to the user -- yuck.

@dehann dehann changed the title Feature/partialinits First state machine tree init May 7, 2019
@dehann dehann added this to the v0.6.0 milestone May 7, 2019
@dehann
Copy link
Member Author

dehann commented May 7, 2019

need to update the compatibility check jld2 file in repo for save and load. VariableNodeData has changed, new field partialinit. Work in progress.

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@89eafef). Click here to learn what that means.
The diff coverage is 13.15%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage          ?   52.77%           
=========================================
  Files             ?       22           
  Lines             ?     2814           
  Branches          ?        0           
=========================================
  Hits              ?     1485           
  Misses            ?     1329           
  Partials          ?        0
Impacted Files Coverage Δ
src/IncrementalInference.jl 19.44% <ø> (ø)
src/SolveTree01.jl 69.59% <0%> (ø)
src/CliqStateMachine.jl 0% <0%> (ø)
src/FactorGraphTypes.jl 74.07% <100%> (ø)
src/DispatchPackedConversions.jl 77.46% <100%> (ø)
src/StateMachine.jl 80% <80%> (ø)
src/FactorGraph01.jl 62.38% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89eafef...7505bb9. Read the comment docs.

@dehann dehann changed the title First state machine tree init First state machine tree init (single core) May 7, 2019
@dehann dehann merged commit d9b4378 into master May 7, 2019
@dehann
Copy link
Member Author

dehann commented May 10, 2019

xref #224

@GearsAD
Copy link
Collaborator

GearsAD commented May 11, 2019

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants