Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parametric performance and Cleanup #1788

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

Affie
Copy link
Member

@Affie Affie commented Oct 17, 2023

restore factor gradient test

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1788 (f084e0b) into master (65e1715) will increase coverage by 0.38%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master    #1788      +/-   ##
==========================================
+ Coverage   68.28%   68.67%   +0.38%     
==========================================
  Files          82       82              
  Lines        5966     5944      -22     
==========================================
+ Hits         4074     4082       +8     
+ Misses       1892     1862      -30     
Files Coverage Δ
src/manifolds/services/ManifoldsExtentions.jl 72.58% <ø> (ø)
src/services/FactorGradients.jl 94.59% <100.00%> (+20.57%) ⬆️
src/parametric/services/ParametricManopt.jl 50.00% <85.71%> (ø)
src/entities/CalcFactor.jl 58.33% <0.00%> (-8.34%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie marked this pull request as ready for review October 17, 2023 14:18
@Affie Affie merged commit 0757330 into master Oct 17, 2023
@Affie Affie self-assigned this Nov 8, 2023
@Affie Affie deleted the 23Q4/parametric/perform branch May 6, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant