Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inner constructor PackedGenericMarginal #1484

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

Affie
Copy link
Member

@Affie Affie commented Feb 10, 2022

close #1483

@Affie Affie added this to the v0.27.0 milestone Feb 10, 2022
@Affie Affie added the bug fix label Feb 10, 2022
Copy link
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah thanks! we should remove the inner constructors that aren't explicitly necessary. I've been pulling them out too.

@dehann dehann marked this pull request as ready for review February 10, 2022 16:30
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #1484 (122c1b2) into master (f9960ed) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
+ Coverage   75.95%   75.96%   +0.01%     
==========================================
  Files          70       70              
  Lines        5048     5046       -2     
==========================================
- Hits         3834     3833       -1     
+ Misses       1214     1213       -1     
Impacted Files Coverage Δ
src/Factors/GenericMarginal.jl 28.57% <ø> (+6.34%) ⬆️
src/NumericalCalculations.jl 91.75% <0.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9960ed...122c1b2. Read the comment docs.

@Affie Affie merged commit 0971eb9 into master Feb 10, 2022
@dehann dehann deleted the 22Q1/bugfix/packedGenMarg_new branch December 16, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

duplicate loading of PackedGenericMarginal
2 participants