Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor hyporecipe #1358

Merged
merged 3 commits into from
Aug 23, 2021
Merged

refactor hyporecipe #1358

merged 3 commits into from
Aug 23, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Aug 19, 2021

I should have separated out the hyporecipe refactoring better. Will suppress the breaking parts of IPC and merge the hyperecipe changes. Must now do in relation to #1361 -- hopefully no conflicts. Let's merge 1361 first.

@dehann dehann marked this pull request as ready for review August 23, 2021 12:27
@dehann dehann changed the title gradients relative still broken, see first test refactor hyporecipe Aug 23, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #1358 (ef342b4) into master (f75bdf4) will decrease coverage by 0.24%.
The diff coverage is 26.47%.

❗ Current head ef342b4 differs from pull request most recent head b182183. Consider uploading reports for the commit b182183 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
- Coverage   75.24%   74.99%   -0.25%     
==========================================
  Files          69       70       +1     
  Lines        4952     4987      +35     
==========================================
+ Hits         3726     3740      +14     
- Misses       1226     1247      +21     
Impacted Files Coverage Δ
src/GraphProductOperations.jl 96.42% <ø> (ø)
src/NumericalCalculations.jl 93.75% <ø> (+1.25%) ⬆️
src/services/EvalFactor.jl 84.61% <16.66%> (-15.39%) ⬇️
src/services/FactorGradients.jl 97.75% <100.00%> (+0.02%) ⬆️
src/ManifoldSampling.jl 26.66% <0.00%> (-62.81%) ⬇️
src/DeconvUtils.jl 58.33% <0.00%> (-1.67%) ⬇️
src/FactorGraph.jl 71.54% <0.00%> (-0.12%) ⬇️
src/Deprecated.jl 0.00% <0.00%> (ø)
src/ODE/DERelative.jl 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9251cb5...b182183. Read the comment docs.

@dehann dehann merged commit 1a27e81 into master Aug 23, 2021
@dehann dehann deleted the 21Q3/enh/relprtls branch December 16, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant