Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null and partial tests #1307

Merged
merged 2 commits into from
Jul 12, 2021
Merged

fix null and partial tests #1307

merged 2 commits into from
Jul 12, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Jul 12, 2021

No description provided.

@dehann dehann added this to the v0.25.0 milestone Jul 12, 2021
@dehann dehann self-assigned this Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #1307 (71dbcce) into master (dd390c1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
  Coverage   10.85%   10.85%           
=======================================
  Files          58       58           
  Lines        4865     4865           
=======================================
  Hits          528      528           
  Misses       4337     4337           
Impacted Files Coverage Δ
src/ApproxConv.jl 53.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd390c1...71dbcce. Read the comment docs.

@dehann
Copy link
Member Author

dehann commented Jul 12, 2021

okay, for the first time in a couple of days the IIF tests are passing again. (cc @Affie )

@dehann dehann merged commit 502df88 into master Jul 12, 2021
@dehann dehann mentioned this pull request Jul 12, 2021
@dehann dehann deleted the 21Q3/fix/testpartialandnull branch March 6, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant