Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for ProductRepr and include SE(2) test #1301

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Conversation

Affie
Copy link
Member

@Affie Affie commented Jul 8, 2021

@Affie Affie added this to the v0.25.0 milestone Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1301 (1a4ba9b) into master (c1e3eaf) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   10.65%   10.54%   -0.11%     
==========================================
  Files          57       57              
  Lines        4861     4854       -7     
==========================================
- Hits          518      512       -6     
+ Misses       4343     4342       -1     
Impacted Files Coverage Δ
src/NumericalCalculations.jl 49.29% <ø> (+0.64%) ⬆️
src/ApproxConv.jl 51.62% <100.00%> (-0.18%) ⬇️
src/FactorGraph.jl 45.92% <0.00%> (-0.59%) ⬇️
src/FGOSUtils.jl 17.72% <0.00%> (ø)
src/DispatchPackedConversions.jl 0.00% <0.00%> (ø)
src/GraphConstraintTypes.jl
src/entities/GraphConstraintTypes.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e3eaf...1a4ba9b. Read the comment docs.

@dehann
Copy link
Member

dehann commented Jul 8, 2021

ah cool

@dehann
Copy link
Member

dehann commented Jul 8, 2021

ready to merge?

@Affie Affie merged commit 589e5e1 into master Jul 8, 2021
@dehann dehann deleted the 21Q2/bugfix/productRepr branch March 6, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants