Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FND w/ typeof(ccw) #1300

Merged
merged 4 commits into from
Jul 8, 2021
Merged

FND w/ typeof(ccw) #1300

merged 4 commits into from
Jul 8, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Jul 8, 2021

No description provided.

@dehann dehann requested a review from Affie July 8, 2021 18:25
@dehann dehann added this to the v0.25.0 milestone Jul 8, 2021
@dehann dehann self-assigned this Jul 8, 2021
@dehann dehann changed the title better types for CCW FND w/ typeof(ccw) Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021 •
edited
Loading

Codecov Report

Merging #1300 (7349828) into master (58d7be2) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 7349828 differs from pull request most recent head 0f7edd4. Consider uploading reports for the commit 0f7edd4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
- Coverage   10.63%   10.61%   -0.02%     
==========================================
  Files          57       57              
  Lines        4860     4859       -1     
==========================================
- Hits          517      516       -1     
  Misses       4343     4343
Impacted Files Coverage Δ
src/CompareUtils.jl 0.00% <0.00%> (ø)
src/DispatchPackedConversions.jl 0.00% <0.00%> (ø)
src/GraphProductOperations.jl 38.09% <0.00%> (ø)
src/FactorGraph.jl 46.39% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d7be2...0f7edd4. Read the comment docs.

@dehann dehann mentioned this pull request Jul 8, 2021
Closed
@dehann dehann merged commit 729b87e into master Jul 8, 2021
Affie
Affie reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@Affie Affie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dehann dehann deleted the 21Q3/enh/extrachanges branch March 6, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Affie Affie Affie left review comments

Assignees

@dehann dehann

Labels
enhancement type stability
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dehann @Affie