Factors return residual for CalcFactorParametric #1139
Conversation
Affie
changed the title
i missed this in an earlier cleanup, cc @Affie
| res .= z - (x2 - x1) | ||
| nothing | ||
| res = z - (x2 - x1) | ||
| return res |
There was a problem hiding this comment.
LinearRelative is <:AbstractRelativeRoots so it needs residual for in-place NLSolve.
Is the plan to handle the residual in another place then?
There was a problem hiding this comment.
This is where residual is currently held (apologies res is too short a name, will fix at some point):
If it makes sense/helps, I have no problem moving residual container elsewhere; perhaps into CalcFactor or even as high as CommonConvWrapper (just remember to respect multithreading -- i.e. ccw.residual::Vector{RESIDUALTYPE}, one for each Threads.nthreads().
I'm not sure what the lifespan of ConvPerThread will be now that we have introduced CalcFactor and _CalcMalahanobisParametric. Also have to revisit FactorMetadata, so we can expect things to change in these parts over the coming weeks.
My suggestion for this general refactor/consolidation (bigger than just #467) would be small steps via PRs and Review that move quickly rather than trying one big jump.
No description provided.