Implementation of NFSP and NFSP_KuhnPoker experiment #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remember to fix the failed CI first. |
findmyway
requested changes
Jul 25, 2021
src/ReinforcementLearningZoo/src/algorithms/nfsp/nfsp_example.jl
Outdated
Show resolved
Hide resolved
src/ReinforcementLearningZoo/src/algorithms/nfsp/nfsp_example.jl
Outdated
Show resolved
Hide resolved
src/ReinforcementLearningZoo/src/algorithms/nfsp/nfsp_extensions.jl
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,140 @@ | |||
| export NFSPAgent | |||
There was a problem hiding this comment.
Just name this file as nfsp.jl ?
There was a problem hiding this comment.
Thanks for your kind suggestions!
I'll merge nfsp_example.jl and nfsp_extensions.jl to nfsp.jl, and move NFSPAgent setting details to the experiment file later.
Please remember to fix the failed CI first.
I'll fix the spellcheck later. And I don't know how to fix the Documentation error. 😞
There was a problem hiding this comment.
Use ## in the comments of JuliaRL_NFSP_KuhnPoker.md file instead of #.
There was a problem hiding this comment.
Thanks! I'll update the file soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for recording my implementation of Neural Fictitious Self-play(NFSP) algorithm and its relative experiments. Former discussions are in #375 #386.