Infinite-recursion bug in function is_discrete_space when an object of type ClosedInterval is passed

[bhatiaabhinav]

The following simple code throws StackOverflowError:

julia> using ReinforcementLearning
julia> env = MountainCarEnv(continuous=true);
julia> action_space(env)
-1.0..1.0
julia> is_discrete_space(action_space(env))
ERROR: StackOverflowError:
Stacktrace:
 [1] is_discrete_space(x::Type) (repeats 79977 times)
   @ ReinforcementLearningEnvironments C:\Users\abhin\.julia\packages\ReinforcementLearningEnvironments\UhI2A\src\converters.jl:3

[bhatiaabhinav]

This is happening because there is no function is_discrete_space(::AbstractInterval) defined in ReinforcementLearningEnvironments\src\converters.jl among all the following definition of the function:

is_discrete_space(x) = is_discrete_space(typeof(x))  # <- leads to infinite recursion when x isa ClosedInterval

is_discrete_space(::Type{<:AbstractVector}) = true
is_discrete_space(::Type{<:Tuple}) = true
is_discrete_space(::Type{<:NamedTuple}) = true

is_discrete_space(::Type{<:Space}) = false

Adding the following code would solve the problem:

using IntervalSets
is_discrete_space(::AbstractInterval) = false

[findmyway]

Or maybe we can simply set the default value to false?

Like

is_discrete_space(::Type) = false

[bhatiaabhinav]

Yeah, whatever works. I like the simplicity/generality of your suggestion.