Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: ChainRules v1.35.3 #62507

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 082447d4-558c-5d27-93f4-14fc19e9eca2
Repo: https://github.com/JuliaDiff/ChainRules.jl.git
Tree: 68938888dad80c4da1db4e7e3c4405c13d0afd13

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in JuliaDiff/ChainRules.jl Jun 17, 2022
* Rewrite getproperty rule to store factors

* Work with factors directly

* Create tangent with factors

* Simplify and generalize cholesky number rule

* Use default tangent

* Generalize diagonal cholesky to Hermitian

* Simplify cholesky(::Diagonal) tests

* Generalize and simplify cholesky(::StridedMatrix)

* Fixes for Hermitian matrices

* Generalize to complex Hermitian matrices

* Remove unnecessary single-arg rule

* Reformat

* Check that check kwarg correctly passed

* Support failed factorizations

* Remove specializations for Thunks

* Release unnecessary constraints on factors

* Decrease step size

* Check complex cotangent for real primal works

* Fix diagonal rule for failed factorization

* Release type constraint of Diagonal

* Refer to real instead off complex

* Increment patch number

* Avoid unnecessary copies

* Update src/rulesets/LinearAlgebra/factorization.jl

Co-authored-by: David Widmann <[email protected]>

* Apply suggestions from code review

Co-authored-by: Frames Catherine White <[email protected]>

* Complexify with concrete types

Co-authored-by: David Widmann <[email protected]>
Co-authored-by: Frames Catherine White <[email protected]>
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch June 17, 2022 11:45 Inactive
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaTagBot JuliaTagBot merged commit f5d32ed into master Jun 17, 2022
@JuliaTagBot JuliaTagBot deleted the registrator/chainrules/082447d4/v1.35.3 branch June 17, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants