New version: ChainRules v0.7.2 #17266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JuliaRegistrator
commented
Jun 30, 2020
JuliaRegistrator
commented
- Registering package: ChainRules
- Repository: https://github.com/JuliaDiff/ChainRules.jl
- Created by: @sethaxen
- Version: v0.7.2
- Commit: 224e553132f26979e7f5c34fccaf769788022299
- Reviewed by: @sethaxen
- Reference: JuliaDiff/ChainRules.jl@224e553#commitcomment-40280797
UUID: 082447d4-558c-5d27-93f4-14fc19e9eca2 Repo: https://github.com/JuliaDiff/ChainRules.jl.git Tree: 9d1951a1686e4849bda5469caadf7de593d56dcd Registrator tree SHA: 58e84c9733c0606ca53349dbce519209d8a8402b
JuliaRegistrator
referenced
this pull request
in JuliaDiff/ChainRules.jl
Jun 30, 2020
* Add rules for evalpoly * Rename pullback * Apply suggestions from code review Co-authored-by: Lyndon White <[email protected]> * Make backx its own method for the future * Update UniformScaling to-dos * Add matrix poly tests * Use correct indices * Reorganize * Use generated functions with fallbacks * Reimplement rules for matrices * Deactivate complex tests Until complex conventions are clarified and FiniteDifferences v0.10.0 is supported. * Add generated functions for tuple case * Add comment * Rename defs to exs * Refactor and test fallbacks * Simplify indexing * Don't store output as an intermediate * Support scalar x with matrix pi * Make extensible for other ps * Move fallback tests under rrule tests * Reorder args and remove unnecessary product * Eliminate unneeded mul and reorganize * Remove unnecessary product * Fix length of ys and wrap lines * Place final ∂yi to in loop This for some reason profiles much faster * Keep other rules consistent with vector * Unify tests * Increment version number * Try equality check outside of tuple * Approximate check due to muladd * Approximate check scalar output too * Decrement version number Co-authored-by: Lyndon White <[email protected]>
|
Your If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.