support for "threads" and "min-optlevel" julia options #493
Conversation
now all long opts are generated with "--arg=val" instead of "--arg val" since julia required arguments support both syntaxes, but optional arguments require the first one
|
It's hard to consider this if none of the tests pas |
|
Hey @dpinol could you rebase on master? The tests should pass now. Thanks! |
@MilesCranmer You might be able to do this yourself. |
|
Hmm, the tests actually look to be failing for this one @dpinol |
| args.append(desc.cli_argument_name()) | ||
| args.append(value) | ||
| if len(desc.cli_argument_name()) == 1: | ||
| args.append(desc.cli_argument_name() + str(value)) |
There was a problem hiding this comment.
Need test case for this branch. (unless there already is one?)
There was a problem hiding this comment.
Wait, there are no options that could trigger this... Is that correct? So maybe this branch can be removed.
|
Okay I think I got it; everything is working now. Had to another options class to allow @mkitti want to give another review? |
| args.append(desc.cli_argument_name()) | ||
| args.append(value) | ||
| if value is None: | ||
| ... |
There was a problem hiding this comment.
I added this new logic to avoid adding arguments if the value is unset. Not sure why this wasn't set up before - @mkitti or @marius311 any idea why?
Codecov ReportBase: 87.37% // Head: 87.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
==========================================
- Coverage 87.37% 87.23% -0.14%
==========================================
Files 39 39
Lines 2320 2342 +22
==========================================
+ Hits 2027 2043 +16
- Misses 293 299 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Looks like we need to run black? |
|
Can we replace distutils at some point? |
Good idea; looks like it will be deprecated for Python 3.12, so we should do it soon. |
Added support for "threads" and "min-optlevel" julia options.
Now all long opts are generated with "--arg=val" instead of "--arg val" since julia required arguments support both syntaxes, but optional arguments require the first one