fix sysimage argument to julia.core.Julia.__init__
#482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On `master` branch, it should be possible to pass a custom "sysimage" to the `julia.core.Julia.__init__` method. However, if the python version in use is statically linked, an UnsupportedPythonError is thrown (despite the sysimage argument having been passed to `__init__`). This commit prevents the UnsupportedPythonError from being thrown if a sysimage keyword argument is passed to `__init__`. Closes #421
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=======================================
Coverage 89.19% 89.20%
=======================================
Files 39 39
Lines 2313 2315 +2
=======================================
+ Hits 2063 2065 +2
Misses 250 250
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
masterbranch, it should be possible to pass a custom "sysimage" to thejulia.core.Julia.__init__method. However, if the python version in use is statically linked, an UnsupportedPythonError is thrown (despite the sysimage argument having been passed to__init__).This commit prevents the UnsupportedPythonError from being thrown if a sysimage keyword argument is passed to
__init__.Closes #421.