Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Julia 1.8 #460

Merged
merged 6 commits into from
Oct 25, 2021
Merged

Support Julia 1.8 #460

merged 6 commits into from
Oct 25, 2021

Conversation

tkf
Copy link
Member

@tkf tkf commented Oct 24, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #460 (5c78705) into master (bee73ec) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   89.00%   89.04%   +0.04%     
==========================================
  Files          39       39              
  Lines        2264     2273       +9     
==========================================
+ Hits         2015     2024       +9     
  Misses        249      249              
Impacted Files Coverage Δ
src/julia/core.py 83.78% <ø> (ø)
src/julia/libjulia.py 92.35% <100.00%> (+0.19%) ⬆️
src/julia/tests/test_sysimage.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee73ec...5c78705. Read the comment docs.

@tkf
Copy link
Member Author

tkf commented Oct 24, 2021

This fails due to

AttributeError: /opt/hostedtoolcache/julia/nightly/x64/bin/../lib/libjulia.so.1: undefined symbol: jl_typeof

https://github.com/JuliaPy/pyjulia/runs/3991096694?check_suite_focus=true#step:8:139

@tkf tkf marked this pull request as ready for review October 25, 2021 04:00
@tkf tkf enabled auto-merge (squash) October 25, 2021 04:52
@tkf tkf merged commit 8d576ad into JuliaPy:master Oct 25, 2021
@tkf tkf deleted the jl18 branch October 25, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant