-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace artifact by scratchspace #3067
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3067 +/- ##
==========================================
- Coverage 62.42% 61.13% -1.30%
==========================================
Files 25 25
Lines 6382 6293 -89
==========================================
- Hits 3984 3847 -137
- Misses 2398 2446 +48
Continue to review full report at Codecov.
|
96685f6
to
80123e1
Compare
@fredrikekre I replaced the artifact by the scratchspace. Could you have a look on this, if this is how it is supposed to be used? |
…into bbs/artifacts
…into bbs/artifacts
Looks ok. For packaging purposes it would of course be nice to repack it as an artifact since you would not have to load Plots etc in order to instantiate it. |
I can't quite follow. Where would that artifact be hosted? |
Anywhere public. |
In #3023 (comment) it was pointed out that this path is never taken, this PR fixes that.
Question is open if that works out or if more needs to be done/ revert the artifact stuff.
Should close #3071