Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace artifact by scratchspace #3067

Merged
merged 15 commits into from
Oct 20, 2020
Merged

Replace artifact by scratchspace #3067

merged 15 commits into from
Oct 20, 2020

Conversation

BeastyBlacksmith
Copy link
Member

@BeastyBlacksmith BeastyBlacksmith commented Oct 15, 2020

In #3023 (comment) it was pointed out that this path is never taken, this PR fixes that.

Question is open if that works out or if more needs to be done/ revert the artifact stuff.

Should close #3071

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #3067 into master will decrease coverage by 1.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
- Coverage   62.42%   61.13%   -1.30%     
==========================================
  Files          25       25              
  Lines        6382     6293      -89     
==========================================
- Hits         3984     3847     -137     
- Misses       2398     2446      +48     
Impacted Files Coverage Δ
src/init.jl 100.00% <100.00%> (+23.33%) ⬆️
src/examples.jl 40.65% <0.00%> (-20.54%) ⬇️
src/subplots.jl 61.11% <0.00%> (-3.89%) ⬇️
src/layouts.jl 60.00% <0.00%> (-3.60%) ⬇️
src/animation.jl 35.29% <0.00%> (-2.91%) ⬇️
src/backends/hdf5.jl 80.09% <0.00%> (-2.78%) ⬇️
src/utils.jl 52.50% <0.00%> (-2.77%) ⬇️
src/output.jl 23.68% <0.00%> (-2.77%) ⬇️
src/types.jl 45.45% <0.00%> (-2.38%) ⬇️
src/args.jl 75.75% <0.00%> (-2.04%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe6a69...003cafa. Read the comment docs.

@BeastyBlacksmith BeastyBlacksmith changed the title Fix the artifact path Replace artifact by scratchspace Oct 17, 2020
@BeastyBlacksmith
Copy link
Member Author

@fredrikekre I replaced the artifact by the scratchspace. Could you have a look on this, if this is how it is supposed to be used?

@fredrikekre
Copy link
Contributor

Looks ok. For packaging purposes it would of course be nice to repack it as an artifact since you would not have to load Plots etc in order to instantiate it.

@BeastyBlacksmith
Copy link
Member Author

I can't quite follow. Where would that artifact be hosted?

@fredrikekre
Copy link
Contributor

Anywhere public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] plotly artifact retrieval failure
2 participants