Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

switch to geometrybasics #351

Merged
merged 31 commits into from
Apr 9, 2020
Merged

switch to geometrybasics #351

merged 31 commits into from
Apr 9, 2020

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Mar 8, 2020 •
edited
Loading

asinghvi17
asinghvi17 reviewed Mar 21, 2020
View reviewed changes
src/interfaces.jl Outdated Show resolved Hide resolved
src/colorsampler.jl
end

function apply_scaling(value::Number, scaling::Scaling)::Float64
value_scaled = scaling.scaling_function(value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would throw an error if given log(0) - would we need to handle this directly in Sampler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@SimonDanisch
Copy link
Member Author

SimonDanisch commented Apr 6, 2020 •
edited
Loading

All 242 tests run without error now :)
Remaining problem:

  • Still needs to fix 3d contour volume plots.

@SimonDanisch
Copy link
Member Author

Ok fuck it! This circular dependency is just too annoying for CI :D I'll merge & tag, and come back to fix CI...

@SimonDanisch SimonDanisch merged commit d460a60 into master Apr 9, 2020
@SimonDanisch SimonDanisch deleted the sd/geometrybasics branch April 9, 2020 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mschauer mschauer mschauer left review comments

@asinghvi17 asinghvi17 asinghvi17 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonDanisch @mschauer @asinghvi17