Bug fix in LegendHDF5IO extension and restructure tests
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
commented
Nov 5, 2024
Comment on lines
+93
to
+111
| @timed_testset "LegendHDF5IO simulate_waveforms" begin | ||
| timed_simulate_waveforms( | ||
| evt_table, | ||
| sim, | ||
| ".", | ||
| chunk_n_physics_events = 1, | ||
| max_nsteps = 4000, | ||
| Δt = 1u"ns", | ||
| number_of_carriers = 20, | ||
| number_of_shells = 2, | ||
| verbose = false | ||
| ) | ||
| @info isfile("generated_waveforms_evts_1-1.h5") | ||
| @test contact_charge_signals == LegendHDF5IO.lh5open("generated_waveforms_evts_1-1.h5") do h5f | ||
| @test haskey(h5f, "generated_waveforms") | ||
| LegendHDF5IO.readdata(h5f.data_store, "generated_waveforms") | ||
| end | ||
| rm("generated_waveforms_evts_1-1.h5") | ||
| end |
There was a problem hiding this comment.
This is the new test, which might get lost in the number of code changes here.
fhagemann
force-pushed
the
hdf5
branch
2 times, most recently
from
8fbff89 to
66414f3
Compare
fhagemann
changed the title
LegendHDF5IO extension and restructure testsLegendHDF5IO extension and restructure tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
simulate_waveformsdoes not work because of some missing packages that have to be explicitly loaded in theLegendHDF5IOextension.Also, I restructured the test directory and added tests for
simulate_waveformsusingLegendHDF5IO.