Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation regarding LegendHDF5IO #427

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

fhagemann
Copy link
Collaborator

Recently, loading LegendHDF5IO before SolidStateDetectors would result in

┌ Warning: Error requiring `LegendHDF5IO` from `SolidStateDetectors`
│   exception =
│    LoadError: ConcurrencyViolationError("deadlock detected in loading SolidStateDetectors -> SolidStateDetectors")

However, all of this is fine if SolidStateDetectors is loaded before LegendHDF5IO.

In the documentation, we previously required all HDF5-related packages to be loaded before SolidStateDetectors. I updated the documentation such that we recommend loading them afterwards. Also, the package HDF5 is no longer explicitly required.

@fhagemann fhagemann added the documentation This issue asks for documentation label Nov 3, 2024
The package HDF5 is no longer required, and LegendHDF5IO should be loaded after loading SolidStateDetectors
@fhagemann fhagemann requested a review from oschulz November 3, 2024 21:30
@fhagemann fhagemann merged commit b41a1f3 into main Nov 3, 2024
9 checks passed
@fhagemann fhagemann deleted the legendhdf5io branch November 3, 2024 22:22
@fhagemann fhagemann removed the request for review from oschulz November 3, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue asks for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant