Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for GPUArrays to 11, (keep existing compat) #422

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the GPUArrays package from 8, 9, 10 to 8, 9, 10, 11.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@fhagemann
Copy link
Collaborator

fhagemann commented Oct 19, 2024

This needs to wait until RecursiveArrayTools.jl allows for GPUArraysCore to 0.2
(otherwise the requirements cannot be met)

Edit: this seems to have happened now: SciML/RecursiveArrayTools.jl@69cbaad

@fhagemann
Copy link
Collaborator

This seems to be the case now with [email protected], let me check how it performs.

@fhagemann
Copy link
Collaborator

From all functions exported by GPUArrays, only AnyGPUArray and AbstractGPUArray are used in SolidStateDetectors:
image

In all cases, the prefix GPUArrays. is already added upfront.

@fhagemann
Copy link
Collaborator

Side note: the current StructArrays prevents the tests from running using GPUArrays@11, so this PR will have to wait sometime until StructArrays supports [email protected].

@fhagemann fhagemann added the dependencies Pull requests that update a dependency file label Nov 15, 2024
@fhagemann fhagemann force-pushed the compathelper/new_version/2024-10-18-00-39-34-530-02598978059 branch 2 times, most recently from b89ea5c to 1b81d21 Compare November 16, 2024 21:15
Looks like everywhere, the prefix GPUArrays is already used
@fhagemann fhagemann force-pushed the compathelper/new_version/2024-10-18-00-39-34-530-02598978059 branch from dadba1d to c25294d Compare November 16, 2024 21:19
@fhagemann
Copy link
Collaborator

Tests are running on [email protected] and GPUArrays@11 now

@fhagemann fhagemann merged commit 78d67b8 into main Nov 18, 2024
10 checks passed
@fhagemann fhagemann deleted the compathelper/new_version/2024-10-18-00-39-34-530-02598978059 branch November 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant