Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Adapt to 4 and for GPUArrays to 10, (keep existing compat) #365

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Adapt package from 3 to 3, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@fhagemann
Copy link
Collaborator

Adapt had breaking changes in Adapt.ndims, Adapt.eltype and Adapt.parent.
Seems like we are only using Adapt.adapt_structure here.
I will test this but I think this should be fine.

GPUArrays is compatible with Adapt 4.0.0 or newer only, so these changes should be merged at once.
@fhagemann fhagemann changed the title CompatHelper: bump compat for Adapt to 4, (keep existing compat) CompatHelper: bump compat for Adapt to 4 and for GPUArrays to 10, (keep existing compat) Dec 27, 2023
@fhagemann
Copy link
Collaborator

fhagemann commented Dec 27, 2023

Wait until ArraysOfArrays.jl and StructArrays.jl support Adapt v4.0.0
JuliaArrays/ArraysOfArrays.jl#40

For better visibility which methods from Adapt are used
@oschulz
Copy link
Member

oschulz commented Dec 28, 2023

New version of ArraysOfArrays is out now.

@fhagemann
Copy link
Collaborator

StructArrays also released a new version 0.6.17.
TypedTables is still missing, but this will not affect this PR.
I'm rerunning the tests, but this should be good to go.

@fhagemann
Copy link
Collaborator

TypedTables also just released a new version

@fhagemann fhagemann merged commit 1b0dfd1 into main Jan 26, 2024
8 checks passed
@fhagemann fhagemann deleted the compathelper/new_version/2023-12-19-00-31-05-052-00608742671 branch January 26, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants