New template, first version. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue with |
|
@vchuravy with the exception of the issue I named above, I think this first version of the template is ready. Suggestions are welcome :) |
|
Out of curiosity: Is there a preview possible or would I have to clone and serve locally using Franklin.jl? |
|
Hi!, I just added a screenshot, I don't have a demo online. |
giordano
reviewed
May 19, 2022
| @@ -1,6 +1,7 @@ | |||
| [deps] | |||
| Franklin = "713c75ef-9fc9-4b05-94a9-213340da978e" | |||
| NodeJS = "2bd173c7-0d6d-553b-b6af-13a54713934c" | |||
| Xranklin = "558449b0-171e-4e1f-900f-d076a5ddf486" | |||
There was a problem hiding this comment.
Or, if it refers to https://github.com/tlienart/Xranklin.jl I you need to check in the manifest (which for the website would be a good idea)
There was a problem hiding this comment.
Follow-up here: #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.