Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nice init function #485

Merged
merged 4 commits into from
Jul 29, 2021
Merged

add nice init function #485

merged 4 commits into from
Jul 29, 2021

Conversation

simonbyrne
Copy link
Member

Fixes #484.

@simonbyrne simonbyrne requested a review from giordano July 29, 2021 18:43
giordano
giordano approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would it be too magical/expensive to check MPI.Finalized in MPI.Init and MPI.Inilized in MPI.Finalized?

@simonbyrne
Copy link
Member Author

Good point. Note that we don't need to check MPI.Initialized in Finalize, since Finalized implies Initialized

@giordano
Copy link
Member 

julia> using MPI

julia> MPI.Finalize()
Attempting to use an MPI routine before initializing MPICH
%

@simonbyrne
Copy link
Member Author

Ah I see. Any MPI operation will give an error like that, so I don't think we need to make Finalize special here.

@simonbyrne simonbyrne merged commit 54cb06e into master Jul 29, 2021
@simonbyrne simonbyrne deleted the sb/init branch July 29, 2021 23:02
@ranocha ranocha mentioned this pull request Jul 30, 2021
Closed
ranocha added a commit to trixi-framework/Trixi.jl that referenced this pull request Jul 30, 2021
@ranocha
update to MPI.jl v0.19
e0d2362 
See JuliaParallel/MPI.jl#485.
Closes #747; closes #748
@ranocha ranocha mentioned this pull request Jul 30, 2021
Merged
sloede pushed a commit to trixi-framework/Trixi.jl that referenced this pull request Aug 11, 2021
@ranocha
update to MPI.jl v0.19 (#749)
071d014 
See JuliaParallel/MPI.jl#485.
Closes #747; closes #748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More user-friendly MPI.Init
2 participants
@simonbyrne @giordano