-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docstrings for one-sided operations #466
Merged
simonbyrne
merged 6 commits into
JuliaParallel:master
from
joachimbrand:docstrings-one-sided
Apr 22, 2021
Merged
docstrings for one-sided operations #466
simonbyrne
merged 6 commits into
JuliaParallel:master
from
joachimbrand:docstrings-one-sided
Apr 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
reviewed
Apr 20, 2021
simonbyrne
reviewed
Apr 20, 2021
These also need to be added to |
joachimbrand
commented
Apr 22, 2021
joachimbrand
commented
Apr 22, 2021
Co-authored-by: Simon Byrne <[email protected]>
… into docstrings-one-sided
Thanks for the review! I amended the PR as suggested. |
simonbyrne
reviewed
Apr 22, 2021
simonbyrne
reviewed
Apr 22, 2021
simonbyrne
reviewed
Apr 22, 2021
Thanks! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I understood what these functions do well enough :-)