Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic error handler functionality #457

Merged
merged 3 commits into from
Apr 8, 2021
Merged

add basic error handler functionality #457

merged 3 commits into from
Apr 8, 2021

Conversation

simonbyrne
Copy link
Member

Fixes #453.

@simonbyrne simonbyrne force-pushed the sb/errorhandler branch 2 times, most recently from 512707c to 6b55d27 Compare March 19, 2021 03:51
@simonbyrne
Copy link
Member Author

simonbyrne commented Mar 23, 2021

Note that mpi4py sets MPI_ERRORS_RETURN on the default communicators:
https://mpi4py.readthedocs.io/en/stable/overview.html#error-handling
should we do the same?

@simonbyrne
Copy link
Member Author

@kpamnany @vchuravy any thoughts on this?

@kpamnany
Copy link
Contributor

kpamnany commented Apr 8, 2021

This looks sensible. However, I've never used this capability, so don't really have any useful input.

@vchuravy
Copy link
Member

vchuravy commented Apr 8, 2021

So this will no longer kill the process on error? That seems sensible, altough you could still end up in a deadlock.

@simonbyrne
Copy link
Member Author

So this will no longer kill the process on error? That seems sensible, altough you could still end up in a deadlock.

Yes, it will throw an MPIError instead.

@simonbyrne simonbyrne merged commit f83140b into master Apr 8, 2021
@simonbyrne simonbyrne deleted the sb/errorhandler branch April 8, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for error handlers
3 participants