-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buffer objects for collective operations #335
Conversation
945f4d1
to
18f2149
Compare
I've updated this, and tests are now passing. All that's left to do is update the tests to get rid of the deprecation warnings, and polish up the docs. I think it's a much more elegant design, as it completely separates the send and receive buffers (potentially allowing for different datatypes to be used for each), and fixes #362. Feedback on buffer names would be appreciated. For now I've gone with Reduction buffers are a bit tricky, since the send and receive buffers have to use the same count and datatype, so I created a new I've had to deprecate the allocating functions One potential thing this does allow is using dispatch to combine some functions, e.g. |
The other question is whether to change |
I would probably not mix this with the buffer changes, as these two components seem to be orthogonal features (at least to me). |
True, but it does avoid another round of deprecations. |
0020d53
to
3125598
Compare
Extending #329 to support collective operations. Thoughts/feedback appreciated.