Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing of PCI domain #77

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

david-macmahon
Copy link
Contributor

Only print the PCI domain if it is non-zero and print it using "%04x:" as the format string.

Only print the PCI domain if it is non-zero and print it using "%04x:"
as the format string.
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8906152) 33.67% compared to head (09fbc37) 33.74%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   33.67%   33.74%   +0.06%     
==========================================
  Files           5        5              
  Lines         962      963       +1     
==========================================
+ Hits          324      325       +1     
  Misses        638      638              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JBlaschke JBlaschke self-requested a review February 17, 2024 23:11
@JBlaschke JBlaschke self-assigned this Feb 17, 2024
@JBlaschke
Copy link
Contributor

I just ran this on Perlmutter -- works fine.

I'm not sure what problem this fixes though. @david-macmahon maybe you can give more context.

@david-macmahon
Copy link
Contributor Author

david-macmahon commented Feb 18, 2024

Before this PR the PCI domain was printed as a Char (i.e. '\x00') rather than as a hexadecimal integer (i.e. 0000). This PR prints the PCI domain as a hexadecimal integer, but only if it is not 0000. When printing to the terminal, the old (pre-PR) and new (post-PR) outputs look the same for PCI domain 0000 because the NUL character of the pre-PR output doesn't display anything and the post-PR behavior is not to print the PCI domain if it is 0000. If you redirect the pre-PR output to a file (or less) you will be able to see the errant NUL character.

@JBlaschke
Copy link
Contributor

Sneaky! Thanks for spotting that.

@JBlaschke JBlaschke merged commit e46ae28 into JuliaParallel:master Feb 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants