Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Base.isempty(::RemoteChannel) #3

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

JamesWrigley
Copy link
Collaborator

@JamesWrigley JamesWrigley commented Oct 26, 2024

The default method from Base has the nasty side-effect of take!()'ing from the underlying channel.

(originally from JuliaLang/Distributed.jl#107, requires #2)

The default method from Base has the nasty side-effect of take!()'ing from the
underlying channel.
@JamesWrigley JamesWrigley self-assigned this Oct 26, 2024
Base automatically changed from passing-tests to master October 29, 2024 20:13
Copy link
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpsamaroo jpsamaroo merged commit 76df474 into master Oct 29, 2024
@jpsamaroo jpsamaroo deleted the remotechannel-empty branch October 29, 2024 20:15
@jpsamaroo jpsamaroo mentioned this pull request Oct 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants