use user given task names in chrome trace

[m-fila]

Adding user defined task names #560 in visualization with :chrome-trace #540 . By default an automatically inferred named is used, if a task has user provided name then it will be used instead

logs_event_pairs is not used anymore as the :data_annotation are not present in it

[jpsamaroo]

logs_event_pairs is not used anymore as the :data_annotation are not present in it

That's a bug, I did something stupid by making the IDs of :data_annotation start/finish not match up (which logs_event_pairs rightly skips over, since it can't then provide a matching pair). Making the ID field in

Dagger.jl/src/utils/logging.jl

Line 140 in 1a317c3

Dagger.TimespanLogging.timespan_finish(ctx, :data_annotation, nothing, nothing)

match the timespan_start line above it would fix this issue.

[m-fila]

Thanks 😃 I found that mismatch but then read the comment # TODO: Remove redundant log event and fought it's intended. I'll fix and update the PR tomorrow

[jpsamaroo]

Awesome, thank you!