DArray: Implement efficient in-place matrix-matrix multiply #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
force-pushed
the
matmul
branch
2 times, most recently
from
75233f4 to
5fc5cf0
Compare
jpsamaroo
changed the title
jpsamaroo
force-pushed
the
matmul
branch
4 times, most recently
from
5d31832 to
2e0decb
Compare
Co-authored-by: Julian P Samaroo <[email protected]>
Co-authored-by: Julian P Samaroo <[email protected]>
Co-authored-by: Julian P Samaroo <[email protected]>
jpsamaroo
force-pushed
the
matmul
branch
5 times, most recently
from
e3b2632 to
0f14a43
Compare
jpsamaroo
force-pushed
the
matmul
branch
2 times, most recently
from
587ae6e to
3c168b2
Compare
Adds optional task-local cache for getindex Adds setindex! operation Fixes lookup_parts indexing fallback for linear indexing Adds allowscalar logic to prevent slow paths Adds first/last helpers
|
Thanks @Rabab53! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
mul!and*using datadepstranspose/adjointusing datadepscopyto!using datadepsgetindexwith optional task-local cachingsetindex!(to be optimized later)julia test/runtests.jl --test array/linalg/matmul --test array/copies)