Stop tracking the manifest files #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These don't really need to be tracked, and it causes conflicts whenever the manifest is changed and you switch branch or something.
jpsamaroo
added
documentation
dependencies
|
This generally LGTM - do you know why the docs build is failing? Maybe the default settings changed upstream? We need to be able to skip some of these missing doc checks until we get that fully fixed up. |
|
Ahh yes, that'll be because #482 is fixed now that ProfileSVG.jl has been updated, so now the docs will be using Documenter.jl v1 which has stricter defaults. I'll update the docs :) |
- Use the latest stable version to build the docs - Use the cache action, should make docs builds faster - Dev all the sub-packages so we don't pull only the latest registered versions of `TimespanLogging` and `DaggerWebDash`.
JamesWrigley
force-pushed
the
rm-manifests
branch
from
55b4e24 to
85df3cb
Compare
|
A bunch of other jobs are still broken, but I don't think that's caused by the manifest being deleted, and it should be working in #463, sooooo I don't think I'll bother fixing that 🙈 |
|
Thanks! Yes those jobs were previously failing, but I haven't had the chance to look into them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think these really need to be tracked, and they cause conflicts whenever the manifest is changed and you switch branch or something.