Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows cputhreadtime fix and 32-bit fixes #251

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Conversation

jpsamaroo
Copy link
Member

No description provided.

@jpsamaroo jpsamaroo added the bug label Aug 6, 2021
@jpsamaroo jpsamaroo linked an issue Aug 6, 2021 that may be closed by this pull request
@jpsamaroo
Copy link
Member Author

jpsamaroo commented Aug 6, 2021

@krynju would you mind looking at the Appveyor Julia 1.0 resolver errors and see if you can come up with a working set of versions for Arrow et. al?

@jpsamaroo jpsamaroo merged commit 9c63657 into master Aug 6, 2021
@jpsamaroo jpsamaroo deleted the jps/windows-fixes branch August 6, 2021 20:14
@krynju
Copy link
Member

krynju commented Aug 7, 2021

@jpsamaroo i have some idea, main issue is arrow with its min 1.3 julia compatibility, but if needed that can be dropped as it doesn't really matter. CSV and DF would be enough to test both interfaces.

However, i tried running Dagger at 1.0 and it doesn't even precompile.
If Dagger were to drop 1.0 compat i can keep Arrow tests I think, but if not then I'll just drop them - CSV is enough

julia> using Dagger
[ Info: Precompiling Dagger [d58978e5-989f-55fb-8d15-ea34adc7bf54]
ERROR: LoadError: LoadError: UndefVarError: Event not defined
Stacktrace:
 [1] getproperty(::Module, ::Symbol) at ./sysimg.jl:13
 [2] top-level scope at none:0
 [3] include at ./boot.jl:317 [inlined]
 [4] include_relative(::Module, ::String) at ./loading.jl:1044
 [5] include at ./sysimg.jl:29 [inlined]
 [6] include(::String) at /home/krynju/.julia/dev/Dagger/src/Dagger.jl:1
 [7] top-level scope at none:0
 [8] include at ./boot.jl:317 [inlined]
 [9] include_relative(::Module, ::String) at ./loading.jl:1044
 [10] include(::Module, ::String) at ./sysimg.jl:29
 [11] top-level scope at none:2
 [12] eval at ./boot.jl:319 [inlined]
 [13] eval(::Expr) at ./client.jl:393
 [14] top-level scope at ./none:3
in expression starting at /home/krynju/.julia/dev/Dagger/src/sch/Sch.jl:35
in expression starting at /home/krynju/.julia/dev/Dagger/src/Dagger.jl:35
ERROR: Failed to precompile Dagger [d58978e5-989f-55fb-8d15-ea34adc7bf54] to /home/krynju/.julia/compiled/v1.0/Dagger/0a2f8.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1203
 [3] _require(::Base.PkgId) at ./loading.jl:960
 [4] require(::Base.PkgId) at ./loading.jl:858
 [5] require(::Module, ::Symbol) at ./loading.jl:853

@jpsamaroo
Copy link
Member Author

Oh, right I forgot about that Event field. Yeah let's drop 1.0 then; 1.3 is a fine release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cputhreadtime() redefinition on Windows
2 participants