Skip to content

Commit

Permalink
Merge pull request #465 from JuliaParallel/jps/no-cache
Browse files Browse the repository at this point in the history
Sch: Temporarily disable chunk cache
  • Loading branch information
jpsamaroo authored Jan 23, 2024
2 parents 2110d62 + 38b1b44 commit 276e4f0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/sch/Sch.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1508,6 +1508,7 @@ function do_task(to_proc, task_desc)
fetch_tasks = map(Iterators.zip(_data,_ids)) do (x, id)
@async begin
timespan_start(ctx, :move, (;thunk_id, id), (;f, id, data=x))
#= FIXME: This isn't valid if x is written to
x = if x isa Chunk
value = lock(TASK_SYNC) do
if haskey(CHUNK_CACHE, x)
Expand Down Expand Up @@ -1548,8 +1549,9 @@ function do_task(to_proc, task_desc)
_x
end
else
@invokelatest move(to_proc, x)
end
=#
x = @invokelatest move(to_proc, x)
#end
@dagdebug thunk_id :move "Moved argument $id to $to_proc: $x"
timespan_finish(ctx, :move, (;thunk_id, id), (;f, id, data=x); tasks=[Base.current_task()])
return x
Expand Down
4 changes: 4 additions & 0 deletions test/scheduler.jl
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,13 @@ function testevicted(x)
x
end
end

@test_skip "Chunk Caching"
#=
@testset "Chunk Caching" begin
compute(delayed(testevicted)(delayed(testpresent)(c1,c2)))
end
=#

@testset "MemPool.approx_size" begin
for (obj, size) in [
Expand Down

0 comments on commit 276e4f0

Please sign in to comment.