[OpenBLAS] Disable TARGET=GENERIC on OpenBLAS 0.3.12 and earlier
#2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that OpenBLAS 0.3.12 and earlier have some kind of `clang`-related code generation bug when built like this. The issue is that the call to `gotoblas->init()` here [0] does not actually call `init` but instead calls `ztrsm_olnncopy`, presumably because of some struct layout issue. I briefly looked into it, but since it only effects `clang` and doesn't effect `0.3.13`, I'm taking the coward's way out and just not poking the compiler bear. [0] https://github.com/xianyi/OpenBLAS/blob/v0.3.10/driver/others/dynamic.c#L921 X-ref: JuliaLang/julia#39719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that OpenBLAS 0.3.12 and earlier have some kind of
clang-related code generation bug when built like this.The issue is that the call to
gotoblas->init()here [0] does notactually call
initbut instead callsztrsm_olnncopy, presumablybecause of some struct layout issue. I briefly looked into it, but
since it only effects
clangand doesn't effect0.3.13, I'm takingthe coward's way out and just not poking the compiler bear.
[0]
https://github.com/xianyi/OpenBLAS/blob/v0.3.10/driver/others/dynamic.c#L921
X-ref: JuliaLang/julia#39719